cmcfarlen commented on code in PR #13044:
URL: https://github.com/apache/trafficserver/pull/13044#discussion_r3018515025
##########
src/iocore/net/SSLUtils.cc:
##########
@@ -401,13 +407,9 @@ ssl_cert_callback(SSL *ssl, [[maybe_unused]] void *arg)
setClientCertCACerts(ssl, sslnetvc->get_ca_cert_file(),
sslnetvc->get_ca_cert_dir());
}
- // Reset the ticket callback if needed
- SSL_CTX *ctx = SSL_get_SSL_CTX(ssl);
-#ifdef HAVE_SSL_CTX_SET_TLSEXT_TICKET_KEY_EVP_CB
- SSL_CTX_set_tlsext_ticket_key_evp_cb(ctx, ssl_callback_session_ticket);
-#else
- SSL_CTX_set_tlsext_ticket_key_cb(ctx, ssl_callback_session_ticket);
-#endif
+ if (!ssl_apply_sni_session_ticket_properties(ssl)) {
+ retval = 0;
+ }
Review Comment:
This is where I was confused trying to resolve conflicts. The old code
calls `set_tlsext_ticket_key...` but the new code path doesn't seem to call
that. So I worry this isn't compatible, but maybe the same thing is
accomplished?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
