bryancall commented on code in PR #13029:
URL: https://github.com/apache/trafficserver/pull/13029#discussion_r3012371502
##########
src/proxy/hdrs/unit_tests/test_Hdrs.cc:
##########
@@ -207,6 +207,7 @@ test_http_hdr_copy_over_aux(int testnum, const char
*request, const char *respon
if (err == ParseResult::ERROR) {
std::printf("FAILED: (test #%d) parse error parsing request hdr\n",
testnum);
+ req_hdr.destroy();
Review Comment:
Agreed, refactored to use `ts::PostScript` scope guards — much cleaner. Also
removed the `goto done` pattern in `test_http_hdr_copy_over_aux` since it was
only needed for centralized cleanup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
