parthchandra commented on issue #3306: URL: https://github.com/apache/datafusion-comet/issues/3306#issuecomment-3814287979
For V1 we choose either `BatchReader` (native_comet) or `NativeBatchReader` (native_iceberg_compat) when we build a partition reader in `CometParquetFileFormat.CometParquetFileFormat` https://github.com/apache/datafusion-comet/blob/62e8c2a79e4c7b6e443ed948c06fa35ce5cc8ac1/spark/src/main/scala/org/apache/comet/parquet/CometParquetFileFormat.scala#L139 The same logic can be applied for V2 in `CometParquetPartitionReaderFactory.buildCometReader` where we are always creating a `BatchReader` https://github.com/apache/datafusion-comet/blob/62e8c2a79e4c7b6e443ed948c06fa35ce5cc8ac1/spark/src/main/scala/org/apache/comet/parquet/CometParquetPartitionReaderFactory.scala#L130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
