milenkovicm commented on code in PR #1420:
URL:
https://github.com/apache/datafusion-ballista/pull/1420#discussion_r2738218552
##########
ballista/core/src/extension.rs:
##########
@@ -528,6 +531,27 @@ impl BallistaQueryPlannerExtension {
}
}
+#[derive(Debug)]
+struct BallistaCacheFactory;
+
+impl BallistaCacheFactory {
+ fn new() -> Self {
+ Self {}
+ }
+}
+
+impl CacheFactory for BallistaCacheFactory {
Review Comment:
can we make cache factory return a logical plan extension, something like
https://github.com/apache/datafusion/blob/20d5f06a554f39407e52dd1d4848267dbc1467ce/datafusion-examples/examples/dataframe/cache_factory.rs#L103
but with two additional properties, session_id and cache_id (populated from
random id), we can then serialize it and send it to scheduler. Scheduler will
then fail as there is no implementation. So when users want to implement cache
they just need to add new query planner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
