blaginin opened a new pull request, #20029:
URL: https://github.com/apache/datafusion/pull/20029

   ## Which issue does this PR close?
   
   Related to https://github.com/apache/datafusion/issues/6880
   
   ## Rationale for this change
   
   When we were testing merge queues for this repo, I made all "rust test" 
steps mandatory. However, those "rust tests" weren't running for PRs that 
change documentation only - and as a result it was impossible to merge those 
PRs: https://github.com/apache/datafusion/pull/17183#issuecomment-3284090122
   
   GitHub doesn't have a way to pair merge queues with `paths-ignore`: 
https://github.com/orgs/community/discussions/45899 - so I had to move those 
checks to a separate step (this is how this problem is solved by the community).
   
   I'm using `dorny/paths-filter` as it has already been approved by ASF and it 
is [desired](https://github.com/apache/infrastructure-actions/pull/312) for us 
to use it.
   
   You'll notice `predicate-quantifier` is marked as an unsupported arg:
   
   <img width="708" height="279" alt="image" 
src="https://github.com/user-attachments/assets/ca741acf-8ab5-4546-b4a1-ca1c5b01cfe9";
 />
   
   This arg is actually used, just not defined in the action definition. Once a 
release with https://github.com/dorny/paths-filter/pull/279 is created, we'll 
switch to the new version and the warning will go away.
   
   ## What changes are included in this PR?
   
   A new action, `rust-required-checks`, that will become mandatory 
(requirement to enable merge queues):
   
   - When there are rust changes, it'll be "green" only when all the previous 
steps are green
   - When there are no rust changes, it gets green right away so we won't have 
to wait
   
   ## Are these changes tested?
   
   Yes:
   
   - Failed change: https://github.com/apache/datafusion-sandbox/pull/144
   - Successful change with rs updates: 
https://github.com/apache/datafusion-sandbox/pull/143
   - md-only updates: https://github.com/apache/datafusion-sandbox/pull/142
   
   ## Are there any user-facing changes?
   
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to