adriangb commented on code in PR #19854:
URL: https://github.com/apache/datafusion/pull/19854#discussion_r2700107171
##########
datafusion/physical-plan/src/filter.rs:
##########
@@ -92,39 +92,124 @@ pub struct FilterExec {
fetch: Option<usize>,
}
+/// Builder for [`FilterExec`] to set optional parameters
+pub struct FilterExecBuilder {
+ predicate: Arc<dyn PhysicalExpr>,
+ input: Arc<dyn ExecutionPlan>,
+ projection: Option<Vec<usize>>,
+ default_selectivity: u8,
+ batch_size: usize,
Review Comment:
In `main` it is also a module level constant by default that gets overridden
with a setter. Forcing it as a constructor parameter would require a lot of
breaking changes (pushing that constant onto the caller wherever there is not
an obvious value available). Could we maybe leave it as is for now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
