shivbhatia10 commented on code in PR #19827:
URL: https://github.com/apache/datafusion/pull/19827#discussion_r2697758116


##########
datafusion/functions/src/regex/regexpreplace.rs:
##########
@@ -659,6 +661,28 @@ mod tests {
 
     use super::*;
 
+    #[test]
+    fn test_regex_replace_posix_groups() {

Review Comment:
   I have checked that this test fails without the fix with the following error:
   
   ```
   thread 'regex::regexpreplace::tests::test_regex_replace_posix_groups' 
(198889) panicked at datafusion/functions/src/regex/regexpreplace.rs:678:9:
   assertion `left == right` failed
     left: "${}"
    right: "\\"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to