kysshsy commented on code in PR #19519:
URL: https://github.com/apache/datafusion/pull/19519#discussion_r2679815125
##########
datafusion/sql/src/resolve.rs:
##########
@@ -193,19 +213,20 @@ pub fn resolve_table_references(
relations: BTreeSet::new(),
all_ctes: BTreeSet::new(),
ctes_in_scope: vec![],
+ normalizer: IdentNormalizer::new(enable_ident_normalization),
};
visit_statement(statement, &mut visitor);
let table_refs = visitor
.relations
.into_iter()
- .map(|x| object_name_to_table_reference(x, enable_ident_normalization))
+ .map(|x| object_name_to_table_reference(x, false))
Review Comment:
I updated `RelationVisitor` to collect normalized `TableReferences`
directly, so we don’t need a second normalization pass.
The only downside is error handling becomes a bit more involved, since
converting to `TableReference` can fail and we now need to propagate that
`Error` during visiting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
