parthchandra commented on code in PR #2897:
URL: https://github.com/apache/datafusion-comet/pull/2897#discussion_r2678150212
##########
native/spark-expr/src/conversion_funcs/cast.rs:
##########
@@ -1076,8 +1076,22 @@ fn cast_array(
cast_options,
)?),
(List(_), Utf8) => Ok(cast_array_to_string(array.as_list(),
cast_options)?),
- (List(_), List(_)) if can_cast_types(from_type, to_type) => {
- Ok(cast_with_options(&array, to_type, &CAST_OPTIONS)?)
+ (List(from), List(to))
+ if can_cast_types(from_type, to_type)
+ || (matches!(from.data_type(), Decimal128(_, _))
Review Comment:
Is this the only case where we have a spark cast but no DF/arrow cast?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
