killzoner commented on code in PR #1374:
URL: 
https://github.com/apache/datafusion-ballista/pull/1374#discussion_r2676167419


##########
ballista/core/src/config.rs:
##########
@@ -31,32 +31,43 @@ use datafusion::{
 pub const BALLISTA_JOB_NAME: &str = "ballista.job.name";
 /// Configuration key for standalone processing parallelism.
 pub const BALLISTA_STANDALONE_PARALLELISM: &str = 
"ballista.standalone.parallelism";
+
+/// Arrow IPC configuration
+
+/// Configuration key for skipping redundant reader validation of Arrow IPC 
valid data.
+pub const BALLISTA_ARROW_IPC_READER_SKIP_VALIDATION: &str =
+    "ballista.arrow.ipc.reader_skip_validation";
+
+/// gRPC configuration
+
+/// Configuration key for gRPC client connection timeout in seconds.
+pub const BALLISTA_GRPC_CLIENT_CONNECT_TIMEOUT_SECONDS: &str =
+    "ballista.grpc.client.connect_timeout_seconds";
+/// Configuration key for HTTP/2 keep-alive interval for gRPC clients in 
seconds.
+pub const BALLISTA_GRPC_CLIENT_HTTP2_KEEPALIVE_INTERVAL_SECONDS: &str =
+    "ballista.grpc.client.http2_keepalive_interval_seconds";

Review Comment:
   reordered some of the keys by alphabetical order / grouped them for clarity 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to