alamb commented on code in PR #19672:
URL: https://github.com/apache/datafusion/pull/19672#discussion_r2670212185
##########
datafusion/core/tests/user_defined/user_defined_scalar_functions.rs:
##########
@@ -1306,19 +1306,14 @@ async fn
create_scalar_function_from_sql_statement_default_arguments() -> Result
"Error during planning: Non-default arguments cannot follow default
arguments.";
assert!(expected.starts_with(&err.strip_backtrace()));
- // FIXME: The `DEFAULT` syntax does not work with positional params
- let bad_expression_sql = r#"
+ let expression_sql = r#"
Review Comment:
nice!
##########
datafusion/expr/src/planner.rs:
##########
@@ -369,9 +369,9 @@ impl PlannedRelation {
#[derive(Debug)]
pub enum RelationPlanning {
/// The relation was successfully planned by an extension planner
- Planned(PlannedRelation),
+ Planned(Box<PlannedRelation>),
Review Comment:
Why is this API changed?
I think this is a breaking API change, so there should be a good reason for
doing so
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
