xudong963 commented on PR #18868: URL: https://github.com/apache/datafusion/pull/18868#issuecomment-3717464712
> 👏 this is a great PR -- thank you @xudong963 I went over the code and tests very carefully and I think it is really nice > > I would personally suggest we merge this one into main and not into 52 to give it maximum "bake time" (testing before release) but I defer to you in that regard Thank you @alamb , I addressed your newest comments in the [commit](https://github.com/apache/datafusion/pull/18868/commits/0e06075983f2df953c48ecab868d15c1201ac2f7). I also like to just merge into main and give it some "bake time". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
