mattcuento commented on PR #1360: URL: https://github.com/apache/datafusion-ballista/pull/1360#issuecomment-3707575395
Hey @milenkovicm, I added support for Substrait on `ExecuteQuery`. My assumption from the epic is that this is strictly intended to be a server-side change for use with different front-ends, and that we won't be changing the client to serialize into Substrait (sounds like that would be an unnecessary extra serialization step on top of `LogicalPlan`). Assuming that's true, it was a little tricky to test this well aside from calling the scheduler RPC service directly ([`test_substrait_compatibility`](https://github.com/apache/datafusion-ballista/pull/1360/changes#diff-7dacf191970a82fbfac6d832289fb555079fe3de0ada9036741996fdf53a84d9R877)). I'm brand new to the project, so if you have any opinions/advice on where or how to better test this do let me know! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
