Brijesh-Thakkar commented on PR #19587: URL: https://github.com/apache/datafusion/pull/19587#issuecomment-3704695930
I ran the relevant checks locally and can confirm the following all pass: cargo fmt --all cargo clippy -p datafusion-common -- -D warnings cargo test -p datafusion-common (including doctests) The remaining failures I saw earlier were from --all-features / benchmark and FFI targets, which appear unrelated to this change and are not required for datafusion-common. The PR now strictly preserves existing tri-state NULL semantics for ScalarValue::partial_cmp, and vector ordering correctly returns None when NULLs are encountered. Thanks for the review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
