Jefffrey commented on PR #19524:
URL: https://github.com/apache/datafusion/pull/19524#issuecomment-3702339237
> hi @Jefffrey
>
> > doesn't seem very ergonomic to essentially require the signature to be
specified twice, once via the original way and then again via the parameters
>
> How about:
>
> ```rust
> // signature for
> // substr(str, start_pos) OR substr(str, start_pos, length)
> Self {
> signature: Signature::from_parameter_variants(
> &[
> vec![
> ("str", string.clone()),
> ("start_pos", int64.clone()),
> ],
> vec![
> ("str", string.clone()),
> ("start_pos", int64.clone()),
> ("length", int64.clone()),
> ],
> ],
> Volatility::Immutable,
> )
>
> ```
I think we should have a discussion on the original issue to agree upon an
API before we raise any PRs. Whilst this API seems fine at a glance, it still
seems a little clunky to me 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
