comphead commented on code in PR #19518:
URL: https://github.com/apache/datafusion/pull/19518#discussion_r2653916249
##########
datafusion/optimizer/src/analyzer/type_coercion.rs:
##########
@@ -794,12 +792,15 @@ fn coerce_arguments_for_signature_with_scalar_udf(
return Ok(expressions);
}
- let current_types = expressions
+ let current_fields = expressions
.iter()
- .map(|e| e.get_type(schema))
+ .map(|e| e.to_field(schema).map(|(_, f)| f))
.collect::<Result<Vec<_>>>()?;
- let new_types = data_types_with_scalar_udf(¤t_types, func)?;
+ let new_types = fields_with_udf(¤t_fields, func)?
Review Comment:
this is not this PR changes, but would be nice to highlight if its new input
types or new output types?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
