Dandandan commented on code in PR #19400:
URL: https://github.com/apache/datafusion/pull/19400#discussion_r2634405971
##########
datafusion/physical-plan/src/coalesce_batches.rs:
##########
@@ -226,6 +227,19 @@ impl ExecutionPlan for CoalesceBatchesExec {
CardinalityEffect::Equal
}
+ fn try_swapping_with_projection(
+ &self,
+ projection: &ProjectionExec,
+ ) -> Result<Option<Arc<dyn ExecutionPlan>>> {
+ match self.input.try_swapping_with_projection(projection)? {
+ Some(new_input) => Ok(Some(Arc::new(
+ CoalesceBatchesExec::new(new_input, self.target_batch_size)
+ .with_fetch(self.fetch),
Review Comment:
I think in this case it's not very different as `CoalesceBatchesExec::new`
does also create a new instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
