JamesVorder commented on code in PR #2134:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2134#discussion_r2631078304
##########
src/parser/mod.rs:
##########
@@ -15188,6 +15137,11 @@ impl<'a> Parser<'a> {
let func_name = self.parse_object_name(true)?;
let func = self.parse_function(func_name)?;
return Ok(Some(TableVersion::Function(func)));
+ } else if dialect_of!(self is DatabricksDialect)
Review Comment:
To demonstrate my thinking here, I've added the following 2 commits, which
result in two failing tests:
*
https://github.com/apache/datafusion-sqlparser-rs/pull/2134/commits/b3534992a082e3c5d13129862843c60b8c42627a
-- `sqlparse_bigquery::parse_table_timetravel` fails after this commit
*
https://github.com/apache/datafusion-sqlparser-rs/pull/2134/commits/759406fc535ca722543d04b545194b477c3c3c98
-- `sqlparse_databricks::parse_table_timetravel` fails after this commit
Are these failures valid, or is my expectation incorrect?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
