Jefffrey commented on code in PR #19235:
URL: https://github.com/apache/datafusion/pull/19235#discussion_r2610515069
##########
datafusion/sqllogictest/test_files/spark/math/hex.slt:
##########
@@ -48,3 +48,26 @@ SELECT hex(column1) FROM t_utf8view;
666F6F
NULL
666F6F62617262617A
+
+statement ok
+CREATE TABLE t_largebinary as VALUES (arrow_cast(arrow_cast('hello',
'Binary'), 'LargeBinary')), (NULL), (arrow_cast(arrow_cast('world', 'Binary'),
'LargeBinary'));
+
+query T
+SELECT hex(column1) FROM t_largebinary;
+----
+68656C6C6F
+NULL
+776F726C64
Review Comment:
```suggestion
query T
SELECT hex(column1) FROM VALUES (arrow_cast('hello', 'LargeBinary')),
(NULL), (arrow_cast('world', 'LargeBinary'));
----
68656C6C6F
NULL
776F726C64
```
So we don't need to worry about cleaning up the table at the end. Also avoid
need for cast from string -> binary -> largebinary, just convert directly to
largebinary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
