andygrove commented on code in PR #2873:
URL: https://github.com/apache/datafusion-comet/pull/2873#discussion_r2608033427
##########
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##########
@@ -149,62 +120,10 @@ object CometSparkSessionExtensions extends Logging {
"org.apache.spark.sql.comet.execution.shuffle.CometShuffleManager"
}
- private[comet] def isCometScanEnabled(conf: SQLConf): Boolean = {
- COMET_NATIVE_SCAN_ENABLED.get(conf)
- }
-
- private[comet] def isCometExecEnabled(conf: SQLConf): Boolean = {
- COMET_EXEC_ENABLED.get(conf)
- }
-
def isCometScan(op: SparkPlan): Boolean = {
op.isInstanceOf[CometBatchScanExec] || op.isInstanceOf[CometScanExec]
}
- def shouldApplySparkToColumnar(conf: SQLConf, op: SparkPlan): Boolean = {
Review Comment:
Moved to `CometExecRule` and made private there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
