andygrove commented on code in PR #2872:
URL: https://github.com/apache/datafusion-comet/pull/2872#discussion_r2607689102
##########
spark/src/main/scala/org/apache/comet/rules/CometExecRule.scala:
##########
@@ -239,6 +325,11 @@ case class CometExecRule(session: SparkSession) extends
Rule[SparkPlan] {
convertToComet(s, CometShuffleExchangeExec).getOrElse(s)
case op =>
+ // Check if this operator has already been tagged with fallback reasons
+ if (hasExplainInfo(op)) {
+ return op
+ }
Review Comment:
Note that this is also a performance optimization in the case where the rule
is applied to a plan multiple times (which does happen with AQE)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
