alamb commented on code in PR #19263:
URL: https://github.com/apache/datafusion/pull/19263#discussion_r2607241252
##########
datafusion/datasource-parquet/src/opener.rs:
##########
@@ -277,8 +277,9 @@ impl FileOpener for ParquetOpener {
// - The table schema as defined by the TableProvider.
// This is what the user sees, what they get when they `SELECT *
FROM table`, etc.
// - The logical file schema: this is the table schema minus any
hive partition columns and projections.
- // This is what the physicalfile schema is coerced to.
- // - The physical file schema: this is the schema as defined by
the parquet file. This is what the parquet file actually contains.
+ // This is what the physical file schema is coerced to.
+ // - The physical file schema: this is the schema that the arrow-rs
Review Comment:
I found the "what the file contains" confusing -- Parquet has different
datatypes than Arrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
