martin-g commented on code in PR #19235:
URL: https://github.com/apache/datafusion/pull/19235#discussion_r2606548964
##########
datafusion/spark/src/function/math/hex.rs:
##########
@@ -52,8 +54,33 @@ impl Default for SparkHex {
impl SparkHex {
pub fn new() -> Self {
+ let int64 = Coercion::new_implicit(
+ TypeSignatureClass::Native(logical_int64()),
+ vec![TypeSignatureClass::Integer, TypeSignatureClass::Numeric],
+ NativeType::Int64,
+ );
+ let string = Coercion::new_implicit(
+ TypeSignatureClass::Native(logical_string()),
+ vec![TypeSignatureClass::Native(logical_string())],
+ NativeType::String,
+ );
+ let binary = Coercion::new_implicit(
+ TypeSignatureClass::Native(logical_binary()),
+ vec![TypeSignatureClass::Binary],
Review Comment:
My comment was about `vec![TypeSignatureClass::Binary],`, not
`logical_binary()`.
https://github.com/apache/datafusion/blob/2a08013af3ccf703bee202c959b40bb0d35bdea1/datafusion/expr-common/src/signature.rs#L340-L341
The comment here mentions (the native) Binary and FixedSizeBinary but
nothing about LargeBinary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
