andygrove opened a new issue, #2859:
URL: https://github.com/apache/datafusion-comet/issues/2859

   ### Describe the bug
   
   The following match arms in `CometExecRule` will never replace replace the 
exchange with a Comet exchange, because the conversion only happens if all 
children are native, and the child in this case is `ReusedExchangeExec `.
   
   This issue became apparent after the recent refactoring work.
   
   ```scala
         case s @ BroadcastQueryStageExec(
               _,
               ReusedExchangeExec(_, _: CometBroadcastExchangeExec),
               _) =>
           convertToCometIfAllChildrenAreNative(s, 
CometExchangeSink).getOrElse(s)
   
         case s @ ShuffleQueryStageExec(_, ReusedExchangeExec(_, _: 
CometShuffleExchangeExec), _) =>
           convertToCometIfAllChildrenAreNative(s, 
CometExchangeSink).getOrElse(s)
   ```
   
   ### Steps to reproduce
   
   _No response_
   
   ### Expected behavior
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to