2010YOUY01 commented on code in PR #17863:
URL: https://github.com/apache/datafusion/pull/17863#discussion_r2575344946


##########
.github/workflows/dev.yml:
##########
@@ -57,3 +58,15 @@ jobs:
             README.md \
             CONTRIBUTING.md
           git diff --exit-code
+
+  typos:
+    name: Spell Check with Typos
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8  # 
v5.0.0
+        with:
+          persist-credentials: false
+      - name: Install typos-cli
+        run: cargo install typos-cli --locked --version 1.37.0

Review Comment:
   No, we can let it auto-upgrade without `--locked --version 1.37.0`, however 
the version is locked on purpose.
   
   I have added comment to explain it in 
[30d8d79](https://github.com/apache/datafusion/pull/17863/commits/30d8d795634e61a3cf9dbea151fbd87d50c8613c):
   ```
   # Version fixed on purpose. It uses heuristics to detect typos, so upgrading 
         # it may cause checks to fail more often.
         - name: Install typos-cli
           run: cargo install typos-cli --locked --version 1.37.0
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to