martin-g commented on code in PR #18998:
URL: https://github.com/apache/datafusion/pull/18998#discussion_r2574852819
##########
datafusion/core/src/datasource/physical_plan/parquet.rs:
##########
Review Comment:
Why `c4(string)` ? It is a Date64
##########
datafusion/core/src/datasource/physical_plan/parquet.rs:
##########
@@ -1272,7 +1272,7 @@ mod tests {
.round_trip_to_batches(vec![batch1, batch2])
.await;
assert_contains!(read.unwrap_err().to_string(),
- "Cannot cast file schema field c3 of type Date64 to table schema
field of type Int8");
+ "Cannot cast column 'c3' from 'Date64' (physical data type) to
'Int8' (logical data type)");
Review Comment:
This looks the opposite to me - Int should be the physical type and Date is
the logical one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
