martin-g commented on code in PR #18984:
URL: https://github.com/apache/datafusion/pull/18984#discussion_r2572576524
##########
datafusion/expr/src/expr_schema.rs:
##########
@@ -46,6 +46,7 @@ pub trait ExprSchemable {
fn nullable(&self, input_schema: &dyn ExprSchema) -> Result<bool>;
/// Given a schema, return the expr's optional metadata
+ #[deprecated(since = "51.0.0", note = "Use new API instead")]
Review Comment:
`Use new API instead` is not really helpful. Please update it to point to
the new API.
```suggestion
#[deprecated(since = "52.0.0", note = "Use to_field() and extract
metadata via FieldMetadata::from(field.metadata()) instead")]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
