alamb commented on code in PR #18592: URL: https://github.com/apache/datafusion/pull/18592#discussion_r2510402520
########## dev/changelog/51.0.0.md: ########## @@ -126,7 +126,6 @@ See the [upgrade guide](https://datafusion.apache.org/library-user-guide/upgradi - feat: Add `reduction_factor` metric to `AggregateExec` for EXPLAIN ANALYZE [#18455](https://github.com/apache/datafusion/pull/18455) (petern48) - feat: support named arguments for aggregate and window udfs [#18389](https://github.com/apache/datafusion/pull/18389) (bubulalabu) - feat: Add selectivity metric to NestedLoopJoinExec for EXPLAIN ANALYZE [#18481](https://github.com/apache/datafusion/pull/18481) (petern48) -- feat: Enhance `array_slice` functionality to support `ListView` and `LargeListView` types [#18432](https://github.com/apache/datafusion/pull/18432) (Weijun-H) Review Comment: I double checked at this commit is not on `branch-51`: - https://github.com/apache/datafusion/commits/branch-51/ I am not sure how it was here previously (I maybe ran the script incorrectly last time) ########## dev/changelog/51.0.0.md: ########## @@ -572,8 +573,6 @@ See the [upgrade guide](https://datafusion.apache.org/library-user-guide/upgradi - Add comments to Cargo.toml about workspace overrides [#18526](https://github.com/apache/datafusion/pull/18526) (alamb) - minor: Remove inconsistent comment [#18539](https://github.com/apache/datafusion/pull/18539) (2010YOUY01) - Refactor `log()` signature to use coercion API + fixes [#18519](https://github.com/apache/datafusion/pull/18519) (Jefffrey) -- chore(deps): bump taiki-e/install-action from 2.62.46 to 2.62.47 [#18508](https://github.com/apache/datafusion/pull/18508) (dependabot[bot]) Review Comment: Similarly to above, these commits are not on `branch-51` so they shouldn't be in the changelog 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
