hsiang-c commented on code in PR #2689:
URL: https://github.com/apache/datafusion-comet/pull/2689#discussion_r2493167640
##########
spark/src/main/scala/org/apache/comet/serde/math.scala:
##########
@@ -144,6 +144,36 @@ object CometUnhex extends CometExpressionSerde[Unhex] with
MathExprBase {
}
}
+object CometAbs extends CometExpressionSerde[Abs] with MathExprBase {
+
+ override def getSupportLevel(expr: Abs): SupportLevel = {
+ expr.child.dataType match {
+ case _: NumericType =>
+ Compatible()
+ case _ =>
+ // Spark supports NumericType, DayTimeIntervalType, and
YearMonthIntervalType
Review Comment:
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
