EmilyMatt commented on code in PR #18325:
URL: https://github.com/apache/datafusion/pull/18325#discussion_r2469941201
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -1359,12 +1360,17 @@ fn evaluate(
.collect()
}
-/// Evaluates expressions against a record batch.
-pub fn evaluate_many(
Review Comment:
Then this function should have been moved somewhere else, there are multiple
copies of the code that does exactly that all over the project, keeping this
specific instance pub is super random, and slightly disruptive, will work
around it to not modify the visibility in this PR's scope and will open an
issue to change that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
