EeshanBembi commented on PR #18137: URL: https://github.com/apache/datafusion/pull/18137#issuecomment-3443868393
> I'm still working through this PR to understand it entirely, but some initial thoughts: > > * We should prefer adding the tests as SLTs and reserve Rust tests for when its difficult to do the test in SLTs > * Why are we removing details that was present in the existing code? I'm seeing comments be removed for no apparently reason, or simplified to lose details. Was this PR LLM-assisted? If so, to what degree? - Sure, I'll do that. - I was removing/reducing comment verbosity after the last review. I think i mixed up the original comments with the boilerplate AI comments. I have not used LLMs post your last review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
