yoavcloud commented on PR #2072:
URL: 
https://github.com/apache/datafusion-sqlparser-rs/pull/2072#issuecomment-3426818401

   > As far as I can understand, the changes made in 
`tests/sqlparser_common.rs` only check that the parse happens without failure, 
but not that it parses to the expected structs.
   
   It tests the full SQL to AST and AST to SQL flow. The new options are added 
to an existing flow, not introducing new AST structs. The existing structs are 
covered in existing tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to