adriangb commented on code in PR #18172:
URL: https://github.com/apache/datafusion/pull/18172#discussion_r2448268669
##########
datafusion/datasource-parquet/src/source.rs:
##########
@@ -720,7 +729,21 @@ impl FileSource for ParquetSource {
let filters: Vec<PushedDownPredicate> = filters
.into_iter()
.map(|filter| {
- if can_expr_be_pushed_down_with_schemas(&filter, &file_schema)
{
+ let schema_with_partition_cols = Arc::new(Schema::new(
+ file_schema
+ .fields()
+ .iter()
+ .cloned()
+ .chain(self.table_partition_cols.iter().cloned())
+ .collect_vec(),
+ ));
+
+ if is_dynamic_physical_expr(&filter)
+ || can_expr_be_pushed_down_with_schemas(
Review Comment:
```suggestion
if can_expr_be_pushed_down_with_schemas(
```
Shouldn't we be able to do just this now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
