Copilot commented on code in PR #1264:
URL:
https://github.com/apache/datafusion-python/pull/1264#discussion_r2411364846
##########
python/tests/test_dataframe.py:
##########
@@ -58,9 +60,7 @@ def ctx():
@pytest.fixture
-def df():
- ctx = SessionContext()
-
+def df(ctx):
Review Comment:
The test fixture signature has changed from `df()` to `df(ctx)` which breaks
the dependency injection pattern. This creates a breaking change for any tests
that use the `df` fixture without also using the `ctx` fixture.
##########
python/datafusion/dataframe.py:
##########
@@ -956,16 +970,20 @@ def write_parquet(
path: str | pathlib.Path,
compression: ParquetWriterOptions,
compression_level: None = None,
+ write_options: DataFrameWriteOptions | None = None,
) -> None: ...
def write_parquet(
self,
path: str | pathlib.Path,
compression: Union[str, Compression, ParquetWriterOptions] =
Compression.ZSTD,
compression_level: int | None = None,
+ write_options: DataFrameWriteOptions | None = None,
) -> None:
"""Execute the :py:class:`DataFrame` and write the results to a
Parquet file.
+ LZO compression is not yet implemented in arrow-rs and is therefore
excluded.
+
Args:
path: Path of the Parquet file to write.
compression: Compression type to use. Default is "ZSTD".
Review Comment:
The documentation comment about LZO compression has been moved from the
compression parameter description to the function description, making it less
clear which parameter it refers to.
```suggestion
Args:
path: Path of the Parquet file to write.
compression: Compression type to use. Default is "ZSTD".
LZO compression is not yet implemented in arrow-rs and is
therefore excluded.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
