comphead commented on code in PR #17651:
URL: https://github.com/apache/datafusion/pull/17651#discussion_r2389544570
##########
datafusion/physical-plan/src/joins/sort_merge_join/tests.rs:
##########
@@ -1314,6 +1314,38 @@ async fn join_left_mark() -> Result<()> {
Ok(())
}
+#[tokio::test]
+async fn join_right_mark() -> Result<()> {
+ let left = build_table(
+ ("a1", &vec![1, 2, 2, 3]),
+ ("b1", &vec![4, 5, 5, 7]), // 7 does not exist on the right
+ ("c1", &vec![7, 8, 8, 9]),
+ );
+ let right = build_table(
+ ("a2", &vec![10, 20, 30, 40]),
+ ("b1", &vec![4, 4, 5, 6]), // 5 is double on the right
Review Comment:
```suggestion
("b1", &vec![4, 4, 5, 6]), // 5 is double on the left
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
