comphead commented on code in PR #2505:
URL: https://github.com/apache/datafusion-comet/pull/2505#discussion_r2395655089
##########
spark/src/test/scala/org/apache/spark/sql/comet/CometPlanStabilitySuite.scala:
##########
@@ -274,13 +259,16 @@ trait CometPlanStabilitySuite extends
DisableAdaptiveExecutionSuite with TPCDSBa
val qe = sql(queryString).queryExecution
val plan = qe.executedPlan
val explain =
normalizeLocation(normalizeIds(qe.explainString(FormattedMode)))
-
+ val simplified = getSimplifiedPlan(plan)
assert(ValidateRequirements.validate(plan))
+ val name = query + suffix
+ val dir = getDirForTest(name)
+
if (regenerateGoldenFiles) {
- generateGoldenFile(plan, query + suffix, explain)
+ generateGoldenFile(dir, simplified, explain)
Review Comment:
`generateGoldenFile` doesn't refer to `name`? prev implementaton referred to
`query + suffix`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
