alamb commented on code in PR #17898:
URL: https://github.com/apache/datafusion/pull/17898#discussion_r2442424904


##########
datafusion/physical-expr/src/expressions/case.rs:
##########
@@ -277,10 +287,15 @@ impl CaseExpr {
         // start with nulls as default output
         let mut current_value = new_null_array(&return_type, batch.num_rows());
         let mut remainder = BooleanArray::from(vec![true; batch.num_rows()]);
+        let mut remainder_count = batch.num_rows();

Review Comment:
   given the similarity of this code and the one above, I wonder if there is 
some way to avoid the duplication (as part of a follow on PR)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to