milenkovicm commented on code in PR #18123: URL: https://github.com/apache/datafusion/pull/18123#discussion_r2441690961
########## datafusion/proto/Cargo.toml: ########## @@ -40,15 +40,31 @@ name = "datafusion_proto" [features] default = ["parquet"] json = ["pbjson", "serde", "serde_json", "datafusion-proto-common/json"] -parquet = ["datafusion/parquet", "datafusion-common/parquet"] -avro = ["datafusion/avro", "datafusion-common/avro"] +parquet = ["datafusion-datasource-parquet", "datafusion-common/parquet", "datafusion/parquet"] +avro = ["datafusion-datasource-avro", "datafusion-common/avro"] + +# Note to developers: do *not* add `datafusion` as a dependency in +# this crate. See https://github.com/apache/datafusion/issues/17713 +# for additional information. [dependencies] arrow = { workspace = true } chrono = { workspace = true } -datafusion = { workspace = true, default-features = false } Review Comment: ```suggestion # direct dependency to datafusion has been removed as it # brings too many other things which make dependant crates # bloated. More details at # https://github.com/apache/datafusion/issues/17713 # datafusion = { workspace = true, default-features = false } ``` maybe we should keep a note here, so it does not come back in the future? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
