wiedld commented on code in PR #17731:
URL: https://github.com/apache/datafusion/pull/17731#discussion_r2374743427
##########
datafusion/expr/src/udaf.rs:
##########
@@ -792,7 +792,7 @@ pub fn udaf_default_schema_name<F: AggregateUDFImpl +
?Sized>(
// exclude the first function argument(= column) in ordered set aggregate
function,
// because it is duplicated with the WITHIN GROUP clause in schema name.
- let args = if func.is_ordered_set_aggregate() {
+ let args = if func.is_ordered_set_aggregate() && !order_by.is_empty() {
Review Comment:
Note that this bug occurred with customers using the older syntax, since it
was shortening the schema names in such a way that they were non-unique is only
the 1st argument was different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
