comphead commented on code in PR #2581:
URL: https://github.com/apache/datafusion-comet/pull/2581#discussion_r2433246439


##########
docs/source/user-guide/latest/compatibility.md:
##########
@@ -83,9 +83,6 @@ The `native_datafusion` scan has some additional limitations:
 Comet will fall back to Spark for the following expressions when ANSI mode is 
enabled, unless
 `spark.comet.expression.allowIncompatible=true`.
 
-- IntegralDivide
-- Remainder
-- Round

Review Comment:
   do we support `round` fully? 
   
   I know we at least fallback to Spark on decimals
   ```Comet cannot accelerate Round because: Comet does not support Spark's 
BigDecimal rounding```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to