BlakeOrth commented on code in PR #18004:
URL: https://github.com/apache/datafusion/pull/18004#discussion_r2421398933
##########
datafusion-cli/examples/cli-session-context.rs:
##########
@@ -84,11 +91,17 @@ impl CliSessionContext for MyUnionerContext {
pub async fn main() {
let my_ctx = MyUnionerContext::default();
+ let profile_mode = InstrumentedObjectStoreMode::default();
Review Comment:
This duplicated code was also bothering me, but I was having trouble of
thinking of a clean way to reduce the duplication at the time. I like this
suggestion. Considering the `InstrumentedObjectStoreRegistry` is currently only
ever used with a `DefaultObjectStoreRegistry` as it's inner I'm inclined to
only implement `with_profile_mode` to avoid functionally dead code. What do you
think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
