andygrove commented on code in PR #2542:
URL: https://github.com/apache/datafusion-comet/pull/2542#discussion_r2426549081
##########
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##########
@@ -3017,6 +3017,32 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
+ test("ANSI support for round function") {
+ Seq((Integer.MAX_VALUE, Integer.MIN_VALUE, Long.MinValue,
Long.MaxValue)).foreach { value =>
Review Comment:
For consistency, it would be good to stick to Scala's constants for min and
max, rather than mixing Java and Scala versions.
```suggestion
Seq((Int.MaxValue Int.MinValue Long.MinValue, Long.MaxValue)).foreach {
value =>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
