tobixdev commented on issue #17488: URL: https://github.com/apache/datafusion/issues/17488#issuecomment-3274822960
> Besides, this NLJ operator also assumes that the left side is the smaller side. This kind of workload is typically not optimized, mostly due to engineering cost — it's easier to implement something fast if users ensure it's used under specific constraints (in this case, large inputs with the smaller side on the left). > However, after checking the code, it seems fixable with some simple rules. I'll give it a try later this week, but if I find that it introduces too much extra complexity, I might give up considering the long-term maintainability. Yeah I agree. Thanks for giving it a try, maybe there is a low-hanging fruit. I wanted to look into a better join ordering strategy for quite a while now, so this might be a good motivation. That said, if this ends up adding complexity to the codebase, I agree it’s probably not worth pursuing. Please feel free to close the issue in that case. I think the reasoning is clear for anyone reading this later. Either way, really appreciate your input! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
