hsiang-c commented on code in PR #2384:
URL: https://github.com/apache/datafusion-comet/pull/2384#discussion_r2354498107
##########
native/spark-expr/Cargo.toml:
##########
@@ -37,6 +37,10 @@ thiserror = { workspace = true }
futures = { workspace = true }
twox-hash = "2.1.2"
rand = { workspace = true }
+datafusion-comet-proto = { workspace = true }
Review Comment:
In 308af77, I moved the `BinaryOutputStyle` proto -> enum mapping from
`spark-expr` to `core` so that I don't need to keep `proto` dependency in
`spark-expr`. The code is cleaner as well.
Thank you for your suggestions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
