alamb commented on code in PR #17524:
URL: https://github.com/apache/datafusion/pull/17524#discussion_r2352750552
##########
datafusion/expr/src/expr.rs:
##########
@@ -3951,7 +3951,7 @@ mod test {
// If this test fails when you change `Expr`, please try
// `Box`ing the fields to make `Expr` smaller
// See https://github.com/apache/datafusion/issues/16199 for details
- assert_eq!(size_of::<Expr>(), 128);
+ assert!(size_of::<Expr>() <= 128);
Review Comment:
I think it would be nicer to include the new, smaller size, in order to
prevent regressions (from the smaller 112 bytes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
