kosiew commented on code in PR #1221:
URL:
https://github.com/apache/datafusion-python/pull/1221#discussion_r2347814350
##########
docs/source/user-guide/dataframe/index.rst:
##########
@@ -126,6 +126,53 @@ DataFusion's DataFrame API offers a wide range of
operations:
# Drop columns
df = df.drop("temporary_column")
+String Columns and Expressions
+------------------------------
+
+Some ``DataFrame`` methods accept plain strings when an argument refers to an
+existing column. These include:
Review Comment:
I will correct this.
##########
python/datafusion/dataframe.py:
##########
@@ -414,9 +418,17 @@ def filter(self, *predicates: Expr) -> DataFrame:
"""Return a DataFrame for which ``predicate`` evaluates to ``True``.
Rows for which ``predicate`` evaluates to ``False`` or ``None`` are
filtered
- out. If more than one predicate is provided, these predicates will be
- combined as a logical AND. If more complex logic is required, see the
- logical operations in :py:mod:`~datafusion.functions`.
+ out. If more than one predicate is provided, these predicates will be
+ combined as a logical AND. Each ``predicate`` must be an
+ :class:`~datafusion.expr.Expr` created using helper functions such as
+ :func:`datafusion.col` or :func:`datafusion.lit`; plain strings are not
+ accepted. If more complex logic is required, see the logical
operations in
+ :py:mod:`~datafusion.functions`.
Review Comment:
I will correct this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
