wForget commented on code in PR #2372:
URL: https://github.com/apache/datafusion-comet/pull/2372#discussion_r2345712676
##########
spark/src/test/scala/org/apache/comet/parquet/ParquetReadFromFakeHadoopFsSuite.scala:
##########
@@ -74,7 +74,18 @@ class ParquetReadFromFakeHadoopFsSuite extends CometTestBase
with AdaptiveSparkP
.startsWith(FakeHDFSFileSystem.PREFIX))
}
- ignore("test native_datafusion scan on fake fs") {
+ // This test fails for 'hdfs' but succeeds for 'open-dal'. 'hdfs' requires
this fix
+ // https://github.com/datafusion-contrib/fs-hdfs/pull/29
+ test("test native_datafusion scan on fake fs") {
+ // Skip test if HDFS feature is not enabled in native library
+ val hdfsEnabled =
+ try {
Review Comment:
Should we extract this try...catch block into a common method in NativeBase?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
