Jefffrey commented on code in PR #17485:
URL: https://github.com/apache/datafusion/pull/17485#discussion_r2340394000
##########
datafusion/spark/src/function/url/parse_url.rs:
##########
@@ -47,23 +46,7 @@ impl Default for ParseUrl {
impl ParseUrl {
pub fn new() -> Self {
Self {
- signature: Signature::one_of(
- vec![
- TypeSignature::Uniform(
- 1,
- vec![DataType::Utf8View, DataType::Utf8,
DataType::LargeUtf8],
- ),
- TypeSignature::Uniform(
- 2,
- vec![DataType::Utf8View, DataType::Utf8,
DataType::LargeUtf8],
- ),
- TypeSignature::Uniform(
- 3,
- vec![DataType::Utf8View, DataType::Utf8,
DataType::LargeUtf8],
- ),
- ],
- Volatility::Immutable,
- ),
+ signature: Signature::user_defined(Volatility::Immutable),
Review Comment:
Dictionary type is another way to represent strings, similar to how view
type is a different way to represent strings.
Can see here in the doc there's a reference to handling dictionary types:
https://github.com/apache/datafusion/blob/351675ddc27c42684a079b3a89fe2dee581d89a2/datafusion/expr-common/src/signature.rs#L229-L239
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
