rkrishn7 commented on code in PR #17452:
URL: https://github.com/apache/datafusion/pull/17452#discussion_r2334247863
##########
datafusion/physical-plan/src/joins/hash_join/shared_bounds.rs:
##########
@@ -294,3 +330,46 @@ impl fmt::Debug for SharedBoundsAccumulator {
write!(f, "SharedBoundsAccumulator")
}
}
+
+/// Utility future to wait until all partitions have reported completion
Review Comment:
Definitely, I was reaching for `Barrier` at first but I didn't see many
tokio sync primitives being used in the crate so I decided against it. Agreed
that using `Barrier` is preferable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
