findepi commented on issue #17087: URL: https://github.com/apache/datafusion/issues/17087#issuecomment-3271214833
I agree it's better to implement value-based equality also for FFI-wrapped functions rather than have pointer-equality-only based one. However, without equivalent of Rust's `Any`, it's not clear how an FFI function would implement equals correctly. Is comparing the pointers only really a big problem? Maybe let's focus on lifecycles of those pointers. The `FFI_ScalarUDF` is not instantiated in DataFusion code. These might be registered once with the session context, are effectively singletons. If this is the case, pointer-based eq is sufficient for most cases. If this is not the case, maybe let's start from describing the scenario, i.e. what problem are we truing to solve. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
